Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "use service_url option for all commands" #25

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Revert "use service_url option for all commands" #25

merged 1 commit into from
Oct 10, 2023

Conversation

mattmurp
Copy link
Collaborator

Reverts #23

@mattmurp mattmurp requested a review from bao-lu October 10, 2023 14:20
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mattmurp mattmurp merged commit 621f091 into main Oct 10, 2023
1 of 2 checks passed
@mattmurp mattmurp deleted the revert-23-serviceOption branch October 10, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bao-lu bao-lu bao-lu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmurp @CLAassistant @bao-lu